Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support bundlers. #48

Merged
merged 2 commits into from
Nov 10, 2021
Merged

feat: Support bundlers. #48

merged 2 commits into from
Nov 10, 2021

Conversation

ShogunPanda
Copy link
Contributor

@ShogunPanda ShogunPanda commented Nov 5, 2021 •
edited
Loading

This PR add supports for using thread-stream in bundled source files.
In particular:

  • It uses real-require to perform dynamic requires/import.
  • It add support for a global variable __bundlerPathsOverrides which bundler plugins can set to override require paths if needed.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1425441030

  • -1 of 5 (80.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.9%) to 82.366%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/worker.js 2 3 66.67%
Totals Coverage Status
Change from base Build 1417248409: -1.9%
Covered Lines: 282
Relevant Lines: 331
💛 - Coveralls

@coveralls
Copy link

coveralls commented Nov 5, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1425731288

  • 4 of 5 (80.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 84.086%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/worker.js 2 3 66.67%
Totals Coverage Status
Change from base Build 1417248409: -0.2%
Covered Lines: 286
Relevant Lines: 331
💛 - Coveralls

@ShogunPanda ShogunPanda mentioned this pull request Nov 5, 2021
Merged
mcollina
mcollina requested changes Nov 5, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are needed

@ShogunPanda
Copy link
Contributor Author

Test added.

mcollina
mcollina approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 514e8ca into pinojs:main Nov 10, 2021
@coveralls
Copy link

coveralls commented Feb 21, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 1425731288

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 5 (80.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 84.516%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/worker.js 2 3 66.67%
Totals Coverage Status
Change from base Build 1417248409: 0.2%
Covered Lines: 287
Relevant Lines: 331
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShogunPanda @coveralls @mcollina